Detailed changes for version 1.024

View previous topic View next topic Go down

Detailed changes for version 1.024

Post  Ellypse on Mon Feb 24, 2014 1:32 pm

You can find here the detailed changes for version 1.024

Changes to totalRP2/totalRP2_API.lua:
TRP2_GetInt():

replaced
Code:
return math.floor(tonumber(value));
for
Code:
if value then
   return math.floor(tonumber(value));
   end
      return 0;
So if an incorrect value is given to the function, it will return 0 instead of giving an error.

Changes to totalRP2/totalRP2_UI_Interface.xml:
Minimap, line 76:

replaced
Code:
<Layer level="OVERLAY">
for
Code:
<Layer level="NORMAL">
To prevent the button texture to be displayed over the border texture. This mean the minimap border will be displayed over the icon, so it might result in a shadow over the icon. This need to be tweaked more

Changes to totalRP2/totalRP2_UI_Registre.xml:
Portrait button, line 2473:

replaced
Code:
<HighlightTexture file="Interface\Minimap\UI-Minimap-ZoomButton-Highlight" alphaMode="ADD"/>
for
Code:
HighlightTexture alphaMode="ADD" file="Interface\Minimap\UI-Minimap-ZoomButton-Highlight">
                     <Size x="41" y="41"/>
                     <Anchors>
                        <Anchor point="CENTER" x="0" y="-3"/>
                     </Anchors>
                  </HighlightTexture>
So the highlight of the button does correspond to the size of the button (previously, the highlight was rendered as half the size of the button, in the center)

Changes to totalRP2_Auras/totalRP2_Auras_Main.lua:
TRP2_UpdateAuraTargetFrame():

replaced
Code:
if not TRP2_Module_Interface["BannedID"][k] and (auraInfo ~= nil or TRP2_AuraTargetFrame.target==TRP2_Joueur.."-"..GetRealmName():gsub("%s+", "") or TRP2_AuraTargetFrame.master == TRP2_Joueur.."-"..GetRealmName():gsub("%s+", "")) then
for
Code:
if not TRP2_Module_Interface["BannedID"][k] and (auraInfo ~= nil or TRP2_SimplifyNameIfPlayer(TRP2_AuraTargetFrame.target) ==TRP2_Joueur or TRP2_SimplifyNameIfPlayer(TRP2_AuraTargetFrame.master)  == TRP2_Joueur) then
Code optimization

replaced
Code:
Message = Message.."{v}< "..TRP2_Auras_Categorie[TRP2_GetInt(tonumber(TRP2_GetWithDefaut(auraInfo,"EtatCat",2)))].." >\n{w}\"{o}"..TRP2_GetWithDefaut(auraInfo,"Description","").."{w}\"";
for
Code:
Message = Message.."{v}< "..TRP2_Auras_Categorie[TRP2_GetWithDefaut(auraInfo,"EtatCat",2)].." >\n{w}\"{o}"..TRP2_GetWithDefaut(auraInfo,"Description","").."{w}\"";
and
Code:
Titre = TRP2_Auras_Color[TRP2_GetInt(TRP2_GetWithDefaut(auraInfo,"Type",2))].."|TInterface\\ICONS\\"..TRP2_GetWithDefaut(auraInfo,"Icone","Temp.blp")..":30:30|t\n"..TRP2_GetWithDefaut(auraInfo,"Nom",TRP2_LOC_NewAura);
for
Code:
Titre = TRP2_Auras_Color[TRP2_GetWithDefaut(auraInfo,"Type",2)].."|TInterface\\ICONS\\"..TRP2_GetWithDefaut(auraInfo,"Icone","Temp.blp")..":30:30|t\n"..TRP2_GetWithDefaut(auraInfo,"Nom",TRP2_LOC_NewAura);
TRP2_GetInt() was not necessary here and was causing a bug when trying to create an aura as the value of "EtatCat" was nil.

Changes to totalRP2_Creation/totalRP2_Creation_Aura.lua:
TRP2_SetAuraApercuTooltip():

replaced
Code:
local Message = "{v}< "..TRP2_Auras_Categorie[TRP2_GetInt(tonumber(TRP2_GetWithDefaut(objet,"EtatCat",2)))].." >\n";
for
Code:
local Message = "{v}< "..TRP2_Auras_Categorie[TRP2_GetWithDefaut(objet,"EtatCat",2)].." >\n";
as TRP2_GetInt was not necessary here and was causing an issue

TRP2_CreateAuraTabCreation():
replaced
Code:
objet["EtatCat"] = TRP2_GetInt(TRP2_DefautToNil(TRP2_CreationFrameAuraFrameGeneralCategorie:GetValue(),2));
for
Code:
objet["EtatCat"] = TRP2_DefautToNil(TRP2_GetInt(TRP2_CreationFrameAuraFrameGeneralCategorie:GetValue()),2);
to correctly call TRP2_GetInt() first

Changes to totalRP2_Interface/totalRP2_Interface_GestionChatFrame.lua:
TRP2_ChatFrame_OnEvent():

added back the function to hide color in names in the chat frame before line 134
Code:
if not TRP2_GetConfigValueFor("UseColorInChat",true) then
        personnage = TRP2_DeleteColorCode(personnage);
end

Changes to totalRP2_Interface/totalRP2_Interface_Main.lua:
TRP2_InitialisationUI():

replaced
Code:
TRP2_WorldMapButtonMenuIcon:SetTexture("Interface\\ICONS\\ABILITY_SEAL");
for
Code:
TRP2_WorldMapButtonMenuIcon:SetTexture("Interface\\ICONS\\inv_misc_map02");
to replace the seal icon on the world map for a map icon

Changes to totalRP2_Inventaire/totalRP2_Inventaire_Main.lua:
TRP2_ExchangeReceiveTab():

replaced
Code:
if tostring(tab[1]) ~= TRP2_Joueur.."-"..GetRealmName():gsub("%s+", "") then
for
Code:
if tostring(TRP2_SimplifyNameIfPlayer(tab[1])) ~= TRP2_Joueur then
Code optimization

Changes to totalRP2_Language/totalRP2_Language_Main.lua:

TRP2_TransformMessage():

added
Code:
TRP2MainFrameLangageMain:Hide();
after
Code:
TRP2_OpenPanelLangues();
As it was actually showing the language frame if the main window was opened when sending a message

Changes to totalRP2_PlayerInfo/totalRP2_PlayerInfo_Main.lua:

TRP2_DD_PotraitIconeClick():

replaced
Code:
if not nom then
         nom, royaume = UnitName("target");
         if not royaume then
              royaume = GetRealmName():gsub("%s+", "");
         end
         nom = nom.."-"..royaume;
    end
for
Code:
if not nom then
      nom = TRP2_UnitNameWithRealm("target");
   end
Code optimization

replaced
Code:
if nom == TRP2_Joueur.."-"..GetRealmName():gsub("%s+", "") then
for
Code:
TRP2_SimplifyNameIfPlayer(nom) == TRP2_Joueur
Code optimization

_________________
Ellypse, Culte de la Rive Noire, FR
Moedra, Kirin Tor, FR
Maison Celwë'Belore, Officer
avatar
Ellypse
Admin

Posts : 215
Join date : 2013-09-26
Age : 26
Location : Paris, France

View user profile http://renaudparize.fr

Back to top Go down

Re: Detailed changes for version 1.024

Post  CMCCallaghan on Wed Feb 26, 2014 5:46 pm

For the layer level the predefined settings are BACKGROUND, BORDER, ARTWORK, OVERLAY, HIGHLIGHT in ascendant order.

A little link. As it is explained somewhere, the default value is ARTWORK so in fact as NORMAL isn't recognize the default value is used instead.
avatar
CMCCallaghan
Developer

Posts : 25
Join date : 2014-02-18

View user profile

Back to top Go down

Re: Detailed changes for version 1.024

Post  Ellypse on Thu Feb 27, 2014 7:51 am

Oh, you're right, thank you for reporting this error. I think I was thinking about something else when I was doing this Rolling Eyes
I will use the correct value in next version.

_________________
Ellypse, Culte de la Rive Noire, FR
Moedra, Kirin Tor, FR
Maison Celwë'Belore, Officer
avatar
Ellypse
Admin

Posts : 215
Join date : 2013-09-26
Age : 26
Location : Paris, France

View user profile http://renaudparize.fr

Back to top Go down

Re: Detailed changes for version 1.024

Post  CMCCallaghan on Fri Feb 28, 2014 1:30 am

there is also an improvement that can be done to avoid issues in FrameXML.log.

in totalRP2_UI_Includes.xml line 615 you should remove file="" as the games tries to load the texture which doesn't exist.
In totalRP2_UI_Registre.xml line 243 and 251 remove file="" too for the same reason.

FrameXML.log is clear of any loading errors after that.
avatar
CMCCallaghan
Developer

Posts : 25
Join date : 2014-02-18

View user profile

Back to top Go down

Re: Detailed changes for version 1.024

Post  Ellypse on Fri Feb 28, 2014 9:43 am

Oh, I didn't know that. I will make the changes. Thank you again  I love you 

_________________
Ellypse, Culte de la Rive Noire, FR
Moedra, Kirin Tor, FR
Maison Celwë'Belore, Officer
avatar
Ellypse
Admin

Posts : 215
Join date : 2013-09-26
Age : 26
Location : Paris, France

View user profile http://renaudparize.fr

Back to top Go down

Re: Detailed changes for version 1.024

Post  Sponsored content


Sponsored content


Back to top Go down

View previous topic View next topic Back to top

- Similar topics

 
Permissions in this forum:
You cannot reply to topics in this forum